chore: remove unused getrandom #524
Conversation
Signed-off-by: Wolf Vollprecht <[email protected]>
wolfv
force-pushed
the
remove-getrandom
branch
from
c041951 to
db99adc
Compare
Signed-off-by: Wolf Vollprecht <[email protected]>
Signed-off-by: Wolf Vollprecht <[email protected]>
The getrandom crate is used only by the wasm feature, through the `ring` dependency. It was explicitly mentioned by our Cargo.toml to enable the `js` feature, required by the `wasm32-unknown-unknown` target. Starting from this commit, we stop mentioning the `getrandom` dependency and instead we make the `ring` dependency explicit. The `js` feature of the getrandom crate is now set by using a dedicated feature of the ring crate itself. Signed-off-by: Flavio Castelli <[email protected]>
Extend the makefile and the GitHub Actions to check also building for the wasm32-unknown-unknown target Signed-off-by: Flavio Castelli <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| - uses: dtolnay/rust-toolchain@351f82a4dc29e4159746a068ed925da17341219f # 1.89.0 | ||
| with: | ||
| targets: wasm32-unknown-unknown |
Check failure
Code scanning / zizmor
commit with no history in referenced repository Error test
| - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: dtolnay/rust-toolchain@351f82a4dc29e4159746a068ed925da17341219f # 1.89.0 |
Check warning
Code scanning / zizmor
commit hash does not point to a Git tag Warning test
|
The getrandom crate is used only by the wasm feature, through the I've pushed a change to this PR to stop mentioning the I've also updated the GHA to include checks for the wasm target. CC @viccuad |
|
Awesome! |
viccuad
left a comment
viccuad
left a comment
There was a problem hiding this comment.
Hi both!
Thanks for the changes, they look good to me. I will wait a bit to merge, to reduce churn on the big Merkle trees' PR rebases.
3 participants
Summary
Release Note
Documentation