pkg: separate pki types from implementations #2668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2668 +/- ##
===========================================
- Coverage 66.46% 26.16% -40.31%
===========================================
Files 92 191 +99
Lines 9258 20122 +10864
===========================================
- Hits 6153 5264 -889
- Misses 2359 14029 +11670
- Partials 746 829 +83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
haydentherapper
previously approved these changes
Nov 5, 2025
Contributor
haydentherapper
left a comment
haydentherapper
left a comment
There was a problem hiding this comment.
Thank you! And thanks for making this backwards compatible as well
Contributor
|
Just need a rebase |
pkg/pki package defines both the interface types for PublicKey and Signature, linked to many external packages, and also all the implementations for pki via static factory map. This separates the types to separate package so the packages that use them can be included without a big dependency chain. The types are aliased to the old pkg/pki package so that this change wouldn't break any backwards compatibility. Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
pki-types-fix
branch
from
1be91d2 to
5db94c5
Compare
haydentherapper
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pkg/pkipackage defines both the interface types forPublicKeyandSignature, linked to many external packages, and also all the implementations for pki via a static factory map.This separates the types to separate packages so the packages that use them can be included without a big dependency chain. The types are aliased to the old pkg/pki package so that this change wouldn't break any backwards compatibility.
This could be cleaned up more in a further refactor when backwards compatibility is not an issue.
Footprint change for
sigstore-go/verifierMost notably, this drops the inclusion of
spf13/cobraCLI framework and its dependencies that somehow is pulled in via x509tools dependency 🤯Release Note
Documentation