add support for sha384 and sha512 to hashedrekord type #1958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1958 +/- ##
===========================================
+ Coverage 47.62% 66.44% +18.82%
===========================================
Files 92 92
Lines 9197 9207 +10
===========================================
+ Hits 4380 6118 +1738
+ Misses 3941 2345 -1596
+ Partials 876 744 -132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
haydentherapper
approved these changes
Jan 17, 2024
| return nil, nil, err | ||
| } | ||
| if err := sigObj.Verify(nil, keyObj, options.WithDigest(decoded)); err != nil { | ||
| if err := sigObj.Verify(nil, keyObj, options.WithDigest(decoded), options.WithCryptoSignerOpts(alg)); err != nil { |
Contributor
There was a problem hiding this comment.
nit for another file: Should we add a comment that the digest in
Line 87 in fc28ac1
Member
Author
There was a problem hiding this comment.
it is a default, so we should probably add that comment. the WithCryptoSignerOpts() already provides a way to override the algorithm.
Member
Author
|
Closed in deference to #1959 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Release Note
Documentation