Skip to content

Reintroduce --logfile with deprecation warning #7723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

michaelsproul
Copy link
Member

Proposed Changes

Reintroduce the --logfile flag with a deprecation warning so that it doesn't prevent nodes from starting. This is considered preferable to breaking node startups so that users fix the flag, even though it means the --logfile flag is completely ineffective.

The flag was initially removed in:

@michaelsproul michaelsproul added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! UX-and-logs v7.1.0 Post-Electra release labels Jul 9, 2025
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 9, 2025
@mergify mergify bot merged commit 8e55684 into sigp:release-v7.1.0 Jul 9, 2025
33 checks passed
ethDreamer pushed a commit to ethDreamer/lighthouse that referenced this pull request Jul 28, 2025
Reintroduce the `--logfile` flag with a deprecation warning so that it doesn't prevent nodes from starting. This is considered preferable to breaking node startups so that users fix the flag, even though it means the `--logfile` flag is completely ineffective.

The flag was initially removed in:

- sigp#6339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge. UX-and-logs v7.1.0 Post-Electra release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants