Skip to content

Fix flaky test_rpc_block_reprocessing #7595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2025

Conversation

ackintosh
Copy link
Member

Issue Addressed

The test occasionally fails, likely because the 10ms fixed delay after block processing isn't insufficient when the system is under load.

#7522 (comment)

Proposed Changes

Replace single assertion with retry loop.

@jimmygchen jimmygchen added the test improvement Improve tests label Jun 13, 2025
@ackintosh ackintosh marked this pull request as ready for review June 13, 2025 20:44
@ackintosh ackintosh requested a review from jxs as a code owner June 13, 2025 20:44
@ackintosh ackintosh added the ready-for-review The code is ready for review label Jun 13, 2025
@ackintosh ackintosh requested a review from jimmygchen June 13, 2025 20:45
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jun 14, 2025
mergify bot added a commit that referenced this pull request Jun 14, 2025
@mergify mergify bot merged commit dc5f5af into sigp:unstable Jun 14, 2025
33 checks passed
@ackintosh ackintosh deleted the retry-flaky-test branch June 15, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. test improvement Improve tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants