Drop stale registrations without reducing CGC #7594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanjay176
approved these changes
Jun 13, 2025
pawanjay176
added
ready-for-merge
6 tasks
jimmygchen
added a commit
that referenced
this pull request
Jun 13, 2025
Squashed commit of the following: commit 52911a3 Author: Jimmy Chen <[email protected]> Date: Thu Jun 12 17:25:11 2025 +0200 Drop stale registrations without reducing CGC.
jimmygchen
added a commit
that referenced
this pull request
Jun 13, 2025
Squashed commit of the following: commit 719df16 Author: Jimmy Chen <[email protected]> Date: Fri Jun 13 16:02:51 2025 +0200 Pop from column_reconstruction_queue. Co-authored-by: dknopik <[email protected]> commit 19113d1 Author: Daniel Knopik <[email protected]> Date: Fri Jun 13 14:16:13 2025 +0200 FORMAT? commit ab94e8a Author: Daniel Knopik <[email protected]> Date: Fri Jun 13 14:12:28 2025 +0200 maybe fix test? commit 0ee7abf Author: Daniel Knopik <[email protected]> Date: Thu Jun 12 16:44:27 2025 +0200 remove obsolete change commit 36ca44d Merge: 5a24f45 5472cb8 Author: Daniel Knopik <[email protected]> Date: Thu Jun 12 16:39:53 2025 +0200 Merge branch 'unstable' into wait-before-reconstruction commit 5a24f45 Author: Daniel Knopik <[email protected]> Date: Thu Jun 12 16:38:15 2025 +0200 refactor commit 891af69 Author: Daniel Knopik <[email protected]> Date: Thu Jun 12 09:28:49 2025 +0200 fmt commit b7c0dd1 Merge: 492d73c 9803d69 Author: Daniel Knopik <[email protected]> Date: Thu Jun 12 09:22:33 2025 +0200 Merge branch 'unstable' into wait-before-reconstruction # Conflicts: # beacon_node/network/src/network_beacon_processor/mod.rs commit 492d73c Author: Daniel Knopik <[email protected]> Date: Wed Jun 11 15:50:28 2025 +0200 make sure to let only retry start reconstruction commit b2f7a5b Author: Daniel Knopik <[email protected]> Date: Wed Jun 11 15:15:44 2025 +0200 correctly reschedule reconstruction commit f813767 Author: Daniel Knopik <[email protected]> Date: Wed Jun 11 14:42:00 2025 +0200 fmt commit c7f5211 Author: Daniel Knopik <[email protected]> Date: Wed Jun 11 14:38:26 2025 +0200 Log and restructure commit 65e5ac4 Author: Daniel Knopik <[email protected]> Date: Wed Jun 11 14:05:50 2025 +0200 Use processor commit e2216c0 Author: Daniel Knopik <[email protected]> Date: Wed Jun 11 09:26:10 2025 +0200 try 100ms commit bef3344 Author: Daniel Knopik <[email protected]> Date: Wed Jun 11 09:07:07 2025 +0200 Logging for testing commit 1eee636 Author: Daniel Knopik <[email protected]> Date: Tue Jun 10 18:05:30 2025 +0200 Wait for more columns before starting reconstruction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Currently the validator effective balance used for computing PeerDAS custody group count is only updated when the validator subscribes to the BN via
validator/beacon_committee_subscriptions.If a validator stops registering with the node, the effective balance gets outdated and stays in the BN memory until the next restart. They are no longer required for CGC computation, as long as the CGC never reduces as per the spec, therefore they can be dropped.