Skip to content

Add genesis sync test to CI #7561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jun 11, 2025
Merged

Conversation

chong-he
Copy link
Member

@chong-he chong-he commented Jun 5, 2025

Issue Addressed

Use existing code from @jimmygchen in #7530 and modify for genesis sync test. Thanks @jimmygchen !

@chong-he chong-he added test improvement Improve tests work-in-progress PR is a work-in-progress syncing infra-ci labels Jun 5, 2025
@chong-he
Copy link
Member Author

chong-he commented Jun 6, 2025

This PR is ready for review. In this test, we use the minimal preset so that it is faster. The local testnet script is also updated to build for minimal:

The rebuild image -b true (link here) is required or Kurtosis wouldn't start

For 120s stop duration, we trigger short distance sync, the lookup sync. We see in the logs:

DEBUG Created block lookup                          peers: [PeerId("16Uiu2HAkzuo2s4zS8Ab1FVPU1GAue212NT3YhHVRgJwE9S1HQ12J")], block_root: 0x149f7747579266942795085564847f3e903de77524ddb59de3077fae5b238432, awaiting_parent: "none", id: 1, service: "lookup_sync"

For 300s stop duration, we trigger long distance sync, the range sync. We see in the logs:

DEBUG Syncing new finalized chain                   id: 1, component: "range_sync"
DEBUG Sync RPC request sent                         method: "BlocksByRange", slots: 8, epoch: 0, peer: 16Uiu2HAm2pJM6EUvzVtN5JwaKyXBx8DAyg9dSXrNPBc81UCP8WBp, id: 3/2/RangeSync/0/1, chain: 1, service: "range_sync"

All sync completed very fast, under 5s. So I reduce the polling time in the script to 0.5s so that we can see some outputs in the terminal, and set a shorter timeout of 5 minutes.

@chong-he chong-he added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Jun 6, 2025
@chong-he chong-he requested a review from jimmygchen June 6, 2025 00:58
@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jun 8, 2025
@mergify mergify bot added the ready-for-review The code is ready for review label Jun 11, 2025
@jimmygchen jimmygchen removed the ready-for-review The code is ready for review label Jun 11, 2025
mergify bot added a commit that referenced this pull request Jun 11, 2025
@mergify mergify bot merged commit 7416d06 into sigp:unstable Jun 11, 2025
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra-ci ready-for-merge This PR is ready to merge. syncing test improvement Improve tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants