Pass blobs into ValidatorStore::sign_block
#7497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michaelsproul Could you please take a look? 🙏 |
|
Some required checks have failed. Could you please take a look @dknopik? 🙏 |
mergify
bot
added
the
waiting-on-author
michaelsproul
added
val-client
michaelsproul
approved these changes
May 21, 2025
michaelsproul
added
ready-for-merge
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
While the Lighthouse implementation of the
ValidatorStoredoes not really care about blobs, Anchor needs to be able to return different blobs fromsign_blocksthan what was passed into it, in case it decides to sign another Anchor node's block. Only passing the unsigned block intosign_blockand only returning a signed block from it (without any blobs and proofs) was an oversight in #6705.Proposed Changes
validator_store::{Uns,S}ignedBlockwithvalidator_store::block_service::{Uns,S}ignedBlock, as we need all data in there.lighthouse_validator_store, just add the received blobs back to the signed block after signing it.