Skip to content

Admin add/remove peer #7198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 28, 2025
Merged

Conversation

pawanjay176
Copy link
Member

Issue Addressed

N/A

Proposed Changes

Adds endpoints to add and remove trusted peers from the http api. The added peers are trusted peers so they won't be disconnected for bad scores. We try to maintain a connection to the peer in case they disconnect from us by trying to dial it every heartbeat.

@pawanjay176 pawanjay176 requested a review from jxs as a code owner March 24, 2025 20:03
@pawanjay176 pawanjay176 mentioned this pull request Mar 24, 2025
14 tasks
@pawanjay176 pawanjay176 added the ready-for-review The code is ready for review label Mar 24, 2025
@eserilev
Copy link
Member

Is it possible to write a test case for this new endpoint?

@michaelsproul michaelsproul added v7.0.0 New release c. Q1 2025 v7.0.0-beta.clean Clean release post Holesky rescue labels Mar 25, 2025
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Mar 28, 2025
mergify bot added a commit that referenced this pull request Mar 28, 2025
Copy link

mergify bot commented Mar 28, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify bot added a commit that referenced this pull request Mar 28, 2025
@mergify mergify bot merged commit 54aef2d into sigp:release-v7.0.0 Mar 28, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. v7.0.0-beta.clean Clean release post Holesky rescue v7.0.0 New release c. Q1 2025
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants