Optimise status processing #7082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a backport from `holesky-rescue`. Co-authored-by: Jimmy Chen <[email protected]>
michaelsproul
added
ready-for-review
14 tasks
dapplion
reviewed
Mar 9, 2025
| // chain. | ||
| if self | ||
| .chain | ||
| .block_root_at_slot(remote_finalized_slot, WhenSlotSkipped::Prev) |
There was a problem hiding this comment.
I'm convinced now that this is very cheap 👍
dapplion
approved these changes
Mar 9, 2025
michaelsproul
added
ready-for-merge
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
This is a backport from
holesky-rescue.Part of:
Original PR to
holesky-rescue:Proposed Changes
Avoid doing database lookups for slots that lie in the hot database when processing status messages. This avoids a DoS vector during non-finality, as loading hot states to iterate block roots is very expensive.