Skip to content

Enable arithmetic lint in rate-limiter #7025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 27, 2025
Merged

Enable arithmetic lint in rate-limiter #7025

merged 6 commits into from
May 27, 2025

Conversation

ackintosh
Copy link
Member

@ackintosh ackintosh commented Feb 21, 2025 •
edited
Loading

Issue Addressed

#6875

Proposed Changes

  • Enabled the linter in rate-limiter and fixed errors.
  • Changed the type of Quota::max_tokens from u64 to NonZeroU64 because max_tokens cannot be zero.
  • Added a test to ensure that a large value for tokens, which causes an overflow, is handled properly.

@ackintosh ackintosh added the work-in-progress PR is a work-in-progress label Feb 21, 2025
@ackintosh ackintosh marked this pull request as ready for review February 24, 2025 23:00
@ackintosh ackintosh requested a review from jxs as a code owner February 24, 2025 23:00
@ackintosh ackintosh added ready-for-review The code is ready for review Networking and removed work-in-progress PR is a work-in-progress labels Feb 24, 2025
@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels May 22, 2025
@jimmygchen
Copy link
Member

@ackintosh ready to review this one - would you mind resolving the conflicts please?

@mergify Mergify
Copy link

mergify bot commented May 23, 2025

All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review.

@mergify mergify bot added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels May 23, 2025
@ackintosh
Copy link
Member Author

@jimmygchen Thanks! I've resolved the conflicts and updated the PR.

@jimmygchen jimmygchen self-requested a review May 26, 2025 12:17
jimmygchen
jimmygchen reviewed May 27, 2025
View reviewed changes
jimmygchen
jimmygchen approved these changes May 27, 2025
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for adding the tests and the explanation!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels May 27, 2025
mergify bot added a commit that referenced this pull request May 27, 2025
@mergify
Merge of #7025
cdd0c5f
@mergify mergify bot mentioned this pull request May 27, 2025
Closed
6 tasks
@jimmygchen jimmygchen mentioned this pull request May 27, 2025
Closed
@mergify mergify bot merged commit 8989ef8 into sigp:unstable May 27, 2025
31 checks passed
@ackintosh ackintosh deleted the arithmetic-lint-in-rate-limiter branch May 29, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

@jxs jxs Awaiting requested review from jxs jxs is a code owner

Assignees
No one assigned
Labels
Networking ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ackintosh @jimmygchen