Skip to content

Fix beacon_chain metrics descriptions #6576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 30, 2025
Merged

Fix beacon_chain metrics descriptions #6576

merged 6 commits into from
Jun 30, 2025

Conversation

rista404
Copy link
Contributor

@rista404 rista404 commented Nov 7, 2024

Issue Addressed

n/a

Proposed Changes

Just fixed a small mistake in the metrics description.

Additional Info

n/a

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rista404 rista404 changed the title Fix typo in beacon_chain metrics Fix beacon_chain metrics descriptions Nov 8, 2024
jxs
jxs approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@michaelsproul michaelsproul changed the base branch from stable to unstable November 14, 2024 02:12
@michaelsproul
Copy link
Member

sorry @rista404, can you rebase on unstable and push a new commit?

Github won't recognise the change of base branch until a new commit is pushed

@rista404
Copy link
Contributor Author

@michaelsproul rebased!

@michaelsproul
Copy link
Member

Thanks!

Just a couple of formatting issues that you can fix with cargo fmt --all and then we're good to go

(see CI failure: https://github.com/sigp/lighthouse/actions/runs/11834376784/job/32976250705?pr=6576)

@rista404
Copy link
Contributor Author

Weird, my editor was supposed to do that.

Done 🙂

@michaelsproul michaelsproul added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! v7.1.0 Post-Electra release labels Jun 24, 2025
@mergify Mergify
Copy link

mergify bot commented Jun 27, 2025

Some required checks have failed. Could you please take a look @rista404? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jun 27, 2025
@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jun 27, 2025
mergify bot added a commit that referenced this pull request Jun 29, 2025
@mergify
Merge of #6576
2e644f9
@mergify mergify bot mentioned this pull request Jun 29, 2025
Closed
6 tasks
@mergify mergify bot merged commit 2d759f7 into sigp:unstable Jun 30, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge. v7.1.0 Post-Electra release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rista404 @CLAassistant @michaelsproul @jimmygchen @jxs