Fix block v3 header decoding #5366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
bug
|
Thanks Mac! |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at bf118a1 |
michaelsproul
added
ready-for-merge
|
Wow! Quick mergify! I guess it realised that the tests had already run against the latest version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
The
eth2client forblocks/v3was incorrectly using hex decoding (my bad). This doesn't have any impact on most Lighthouse users, as our VC doesn't care about this value, and the actual value in the response is correct, so other VCs are able to parse it.This is relevant for projects that import Lighthouse's HTTP client, like
blockdreamer.Proposed Changes
Uint256::from_hex("0") == Uint256::from_dec("0").