Skip to content

Fix 5288: Doesn't POST if attestations is empty. #5318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Fix 5288: Doesn't POST if attestations is empty. #5318

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8619b2
fix: issue 5288
kamuik16 Feb 27, 2024
8806f2b
added log argument
kamuikatsurgi Feb 27, 2024
0140ac3
changed to is_empty() and removed WARN
kamuik16 Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions validator_client/src/attestation_service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,11 @@ impl<T: SlotClock + 'static, E: EthSpec> AttestationService<T, E> {
.flatten()
.unzip();

if attestations.len() == 0 {
warn!("WARN: No attestations were published");
return Ok(None);
}

// Post the attestations to the BN.
match self
.beacon_nodes
Expand Down