Skip to content

Conversation

jimmygchen
Copy link
Member

Issue Addressed

Another attempt to fix our flaky CI tests due to port conflicts.

Example failure:
https://github.com/sigp/lighthouse/actions/runs/7966087945/job/21746780132

Proposed Changes

  • Remove use of constant ports for tests that binds the ports. The DUMMY_ENR_ ports were meant to be used for enr-xxx-port flag only, and should not be bound, i.e. they must not be used for port or discovery-port.

@jimmygchen jimmygchen added the ready-for-review The code is ready for review label Feb 20, 2024
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I've opened #5267 to track further improvements to unused_port, as these tests will still be a bit racy

@jimmygchen jimmygchen force-pushed the fix-tests-addr-in-use branch from b2738ab to a54372e Compare February 20, 2024 01:19
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 21, 2024
@michaelsproul
Copy link
Member

@Mergifyio queue

Copy link

mergify bot commented Feb 25, 2024

queue

🛑 The pull request has been removed from the queue default

Pull request #5266 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@michaelsproul
Copy link
Member

@Mergifyio dequeue

Copy link

mergify bot commented Feb 26, 2024

dequeue

✅ The pull request has been removed from the queue default

@michaelsproul
Copy link
Member

@Mergifyio requeue

Copy link

mergify bot commented Feb 26, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Feb 26, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@AgeManning
Copy link
Member

@Mergifyio requeue

Copy link

mergify bot commented Feb 28, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Feb 28, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

Copy link

mergify bot commented Mar 7, 2024

requeue default

✅ This pull request will be re-embarked automatically

The followup queue default command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Mar 7, 2024

queue default

🛑 The pull request has been removed from the queue default

Pull request #5266 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

Copy link

mergify bot commented Mar 7, 2024

queue

🛑 The pull request has been removed from the queue default

Pull request #5266 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

Copy link

mergify bot commented Mar 7, 2024

dequeue

✅ The pull request has been removed from the queue default

@jimmygchen
Copy link
Member Author

@mergify requeue

Copy link

mergify bot commented Mar 8, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Mar 8, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Mar 8, 2024
mergify bot added a commit that referenced this pull request Mar 8, 2024
@paulhauner
Copy link
Member

@mergify requeue

Copy link

mergify bot commented Mar 8, 2024

requeue

☑️ This pull request is already queued

@jimmygchen
Copy link
Member Author

@mergify dequeue

Copy link

mergify bot commented Mar 8, 2024

dequeue

☑️ The pull request is not queued

@jimmygchen
Copy link
Member Author

@mergify requeue

Copy link

mergify bot commented Mar 8, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Mar 8, 2024

queue

🛑 The pull request has been removed from the queue default

Pull request #5266 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Mar 8, 2024
@paulhauner
Copy link
Member

@mergify dequeue

Copy link

mergify bot commented Mar 8, 2024

dequeue

✅ The pull request has been removed from the queue default

@paulhauner
Copy link
Member

@mergify requeue

Copy link

mergify bot commented Mar 8, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Mar 8, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 762dab2

mergify bot added a commit that referenced this pull request Mar 8, 2024
@mergify mergify bot merged commit 762dab2 into sigp:unstable Mar 8, 2024
@paulhauner paulhauner mentioned this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants