Small Readability Improvement in Sync Code #5098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realbigsean
approved these changes
Jan 20, 2024
dapplion
reviewed
Jan 21, 2024
| let block_already_downloaded = self.block_already_downloaded(); | ||
| let blobs_already_downloaded = self.blobs_already_downloaded(); | ||
|
|
||
| if block_already_downloaded && blobs_already_downloaded { | ||
| trace!(cx.log, "Lookup request already completed"; "block_root"=> ?block_root); |
There was a problem hiding this comment.
Is the deletion of this trace log statement intentional?
There was a problem hiding this comment.
yeah.. I don't think this log is very useful. There are hardly any tracing logs in this code & I just spent a long time tracking down a bug in this code & it required me to put a bunch of additional logs all over the place. I never turned on trace logs because there are hardly any of them and none of them would've helped me debug anyway, they would've only cluttered the output and made it more difficult.
danielrachi1
pushed a commit
to danielrachi1/lighthouse
that referenced
this pull request
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small code change that I think improves readability. Though maybe I'm not understanding why it was originally written the way it was..