Use the mesh_n value from NetworkLoad for PeerScoreSettings

[jimmygchen]

Issue Addressed

We're using the libp2p default gs_config here for PeerScoreSettings:

lighthouse/beacon_node/lighthouse_network/src/service/mod.rs

Line 180 in 6c0c41c

let score_settings = PeerScoreSettings::new(ctx.chain_spec, &config.gs_config);

and then we build a Lighthouse specific one here and use it for Gossipsub

lighthouse/beacon_node/lighthouse_network/src/service/mod.rs

Lines 266 to 273 in 6c0c41c

	let snappy_transform = SnappyTransform::new(config.gs_config.max_transmit_size());
	let mut gossipsub = Gossipsub::new_with_subscription_filter_and_transform(
	MessageAuthenticity::Anonymous,
	config.gs_config.clone(),
	gossipsub_metrics,
	filter,
	snappy_transform,
	)

The only value that is used for initialising PeerScoreSettings from the gs_config appears to be the mesh degree mesh_n, which is taken from NetworkLoad.

Proposed Changes

Build the correct gs_config and use the mesh_n value for PeerScoreSetttings.
Note that the score settings needs a bit of rework, so this would just be a temporary fix.

The impact of this fix is that scoring will now use the mesh_n from NetworkLoad (default to 4) rather than the libp2p2 hard coded value (6).

[jimmygchen]

Marking this as work-in-progress as this PR is mainly for tracking and need some review from @AgeManning

[pawanjay176]

So much cleaner!

[realbigsean]

@Mergifyio queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d30ba97