[Merged by Bors] - more logging improvements #4885
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realbigsean
added
ready-for-review
pawanjay176
approved these changes
Oct 26, 2023
| @@ -786,7 +786,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> { | |||
| self.log, | |||
| "Block component processed for lookup"; | |||
| "response_type" => ?R::response_type(), | |||
| "result" => ?result, | |||
There was a problem hiding this comment.
does it make sense to log the block_root here?
realbigsean
added
ready-for-merge
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 3, 2023
## Issue Addressed -downgrades `Missing components over rpc` to debug because this isn't unusual and just results in a re-try -removes the result from `Block component processed for lookup` because this prints the full block on an unknown parent error Co-authored-by: realbigsean <[email protected]>
|
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
-downgrades
Missing components over rpcto debug because this isn't unusual and just results in a re-try-removes the result from
Block component processed for lookupbecause this prints the full block on an unknown parent error