Skip to content

[Merged by Bors] - fix typos #4838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix typos #4838

wants to merge 1 commit into from

Conversation

GoodDaisy
Copy link
Contributor

@GoodDaisy GoodDaisy commented Oct 12, 2023 •
edited by bors bot
Loading

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 12, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jimmygchen jimmygchen added the ready-for-review The code is ready for review label Oct 18, 2023
realbigsean
realbigsean approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@realbigsean
Copy link
Member

bors r+

@bors
Copy link

bors bot commented Oct 18, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@bors
Copy link

bors bot commented Oct 18, 2023

👎 Rejected by PR status

@jimmygchen jimmygchen changed the base branch from stable to unstable October 19, 2023 00:20
@jimmygchen
Copy link
Member

I've changed the target branch to unstable.

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Oct 19, 2023
@jimmygchen
Copy link
Member

ah looks like this was built on top of stable rather than unstable.

@GoodDaisy would you mind making the change from unstable instead please?

@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-merge This PR is ready to merge. labels Oct 19, 2023
@GoodDaisy
Copy link
Contributor Author

GoodDaisy commented Oct 19, 2023 •
edited
Loading

@jimmygchen I want to change to unstable branch, but I don't know how to change it in this PR. So I have push my unstable branch to my stable branch, that's to say, both the stable and unstable branches are the same in my repo.
Please help me to review again, thank you very much.

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Oct 19, 2023
@AgeManning
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 19, 2023
@GoodDaisy
fix typos (#4838)
90f78d1
@bors
Copy link

bors bot commented Oct 19, 2023

Pull request successfully merged into unstable.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title fix typos [Merged by Bors] - fix typos Oct 19, 2023
@bors bors bot closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realbigsean realbigsean realbigsean approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GoodDaisy @CLAassistant @realbigsean @jimmygchen @AgeManning