[Merged by Bors] - Fix Rayon deadlock in test utils #4837
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
test improvement
michaelsproul
added
ready-for-merge
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
## Issue Addressed Fix a deadlock in the tests that was causing tests on tree-states to run for hours without finishing: https://github.com/sigp/lighthouse/actions/runs/6491194654/job/17628138360. ## Proposed Changes Avoid using a Mutex under the Rayon `par_iter`. Instead, use an `AtomicUsize`. I've run the new version several times in a loop and it hasn't deadlocked (it was deadlocking consistently on tree-states). ## Additional Info The same bug exists in unstable and tree-states, but I'm not sure why it was triggering so consistently on the tree-states branch.
|
bors cancel |
|
Canceled. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
## Issue Addressed Fix a deadlock in the tests that was causing tests on tree-states to run for hours without finishing: https://github.com/sigp/lighthouse/actions/runs/6491194654/job/17628138360. ## Proposed Changes Avoid using a Mutex under the Rayon `par_iter`. Instead, use an `AtomicUsize`. I've run the new version several times in a loop and it hasn't deadlocked (it was deadlocking consistently on tree-states). ## Additional Info The same bug exists in unstable and tree-states, but I'm not sure why it was triggering so consistently on the tree-states branch.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
## Issue Addressed Fix a deadlock in the tests that was causing tests on tree-states to run for hours without finishing: https://github.com/sigp/lighthouse/actions/runs/6491194654/job/17628138360. ## Proposed Changes Avoid using a Mutex under the Rayon `par_iter`. Instead, use an `AtomicUsize`. I've run the new version several times in a loop and it hasn't deadlocked (it was deadlocking consistently on tree-states). ## Additional Info The same bug exists in unstable and tree-states, but I'm not sure why it was triggering so consistently on the tree-states branch.
|
bors r+ |
|
Already running a review |
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
## Issue Addressed Fix a deadlock in the tests that was causing tests on tree-states to run for hours without finishing: https://github.com/sigp/lighthouse/actions/runs/6491194654/job/17628138360. ## Proposed Changes Avoid using a Mutex under the Rayon `par_iter`. Instead, use an `AtomicUsize`. I've run the new version several times in a loop and it hasn't deadlocked (it was deadlocking consistently on tree-states). ## Additional Info The same bug exists in unstable and tree-states, but I'm not sure why it was triggering so consistently on the tree-states branch.
|
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
Gua00va
pushed a commit
to Gua00va/lighthouse
that referenced
this pull request
Oct 18, 2023
## Issue Addressed Fix a deadlock in the tests that was causing tests on tree-states to run for hours without finishing: https://github.com/sigp/lighthouse/actions/runs/6491194654/job/17628138360. ## Proposed Changes Avoid using a Mutex under the Rayon `par_iter`. Instead, use an `AtomicUsize`. I've run the new version several times in a loop and it hasn't deadlocked (it was deadlocking consistently on tree-states). ## Additional Info The same bug exists in unstable and tree-states, but I'm not sure why it was triggering so consistently on the tree-states branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fix a deadlock in the tests that was causing tests on tree-states to run for hours without finishing: https://github.com/sigp/lighthouse/actions/runs/6491194654/job/17628138360.
Proposed Changes
Avoid using a Mutex under the Rayon
par_iter. Instead, use anAtomicUsize. I've run the new version several times in a loop and it hasn't deadlocked (it was deadlocking consistently on tree-states).Additional Info
The same bug exists in unstable and tree-states, but I'm not sure why it was triggering so consistently on the tree-states branch.