[Merged by Bors] - Address Clippy 1.73 lints #4809
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
michaelsproul
commented
Oct 5, 2023
Comment on lines
+339
to
+341
| self.score() | ||
| .partial_cmp(&other.score()) | ||
| .unwrap_or(std::cmp::Ordering::Equal) |
There was a problem hiding this comment.
Clippy thought the old impl was pretty suspicious.
The effect of Clippy's suggested change is that partial_ord will never return None for incomparable values (like NaN). I think this is OK, as we shouldn't be encountering this anyway (fingers crossed).
There was a problem hiding this comment.
It doesn't look like there are any other scenarios (other than comparing NaN) where f64::partial_cmp would return None, so this is probably fine 🤞
jimmygchen
approved these changes
Oct 6, 2023
jimmygchen
added
ready-for-merge
|
Thanks! bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
## Proposed Changes Fix Clippy lints enabled by default in Rust 1.73.0, released today.
|
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
pawanjay176
pushed a commit
that referenced
this pull request
Oct 6, 2023
* Address Clippy 1.73 lints (#4809) ## Proposed Changes Fix Clippy lints enabled by default in Rust 1.73.0, released today. * Address Clippy 1.73 lints. --------- Co-authored-by: Michael Sproul <[email protected]>
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Proposed Changes Fix Clippy lints enabled by default in Rust 1.73.0, released today.
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Proposed Changes Fix Clippy lints enabled by default in Rust 1.73.0, released today.
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Proposed Changes Fix Clippy lints enabled by default in Rust 1.73.0, released today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fix Clippy lints enabled by default in Rust 1.73.0, released today.