Skip to content

[Merged by Bors] - Correct checks for backfill completeness #4465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Correct checks for backfill completeness #4465

wants to merge 5 commits into from

Conversation

jmcph4
Copy link
Contributor

@jmcph4 jmcph4 commented Jul 5, 2023

Issue Addressed

#4331

Proposed Changes

  • Use comparison rather than strict equality between the earliest epoch we know about and the backfill target (which will be the most recent WSP by default or genesis)
  • Add helper function BackFillSync<T>::would_complete to achieve this in one location

Additional Info

@jmcph4 jmcph4 requested a review from AgeManning July 5, 2023 03:59
@jmcph4 jmcph4 self-assigned this Jul 5, 2023
@jmcph4 jmcph4 added the v4.4.1 ETA August 2023 label Jul 5, 2023
divagant-martian
divagant-martian approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@divagant-martian divagant-martian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this looks like what I had in mind. LGTM

Also checked that the test now passes

@jmcph4 jmcph4 added Networking ready-for-review The code is ready for review labels Jul 5, 2023
AgeManning
AgeManning approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good

@AgeManning AgeManning added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 6, 2023
@AgeManning
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jul 6, 2023
@jmcph4 @AgeManning
Correct checks for backfill completeness (#4465)
a6d5c7d 
## Issue Addressed

#4331 

## Proposed Changes

 - Use comparison rather than strict equality between the earliest epoch we know about and the backfill target (which will be the most recent WSP by default or genesis)
 - Add helper function `BackFillSync<T>::would_complete` to achieve this in one location

## Additional Info

 - There's an ad hoc test for this in #4461


Co-authored-by: Age Manning <[email protected]>
@bors
Copy link

bors bot commented Jul 6, 2023

Pull request successfully merged into unstable.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Correct checks for backfill completeness [Merged by Bors] - Correct checks for backfill completeness Jul 6, 2023
@bors bors bot closed this Jul 6, 2023
This was referenced Jul 7, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgeManning AgeManning AgeManning approved these changes

+1 more reviewer

@divagant-martian divagant-martian divagant-martian approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jmcph4 jmcph4

Labels
Networking ready-for-merge This PR is ready to merge. v4.4.1 ETA August 2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmcph4 @AgeManning @divagant-martian