[Merged by Bors] - Update Lighthouse Book API and Advanced Usage section #4300

chong-he · 2023-05-17T01:47:29Z

Issue Addressed

Update Information in Lighthouse Book

Proposed Changes

move Validator Graffiti from Advanced Usage to Validator Management
update API response and command
some items that aren't too sure I put it in comment, which can be seen in raw/review format but not live

Additional Info

Please provide any additional information. For example, future considerations
or information useful for reviewers.

paulhauner

Wow, this is a big effort! It makes lots of overdue fixes and I think it's a great improvement! 🚀

I've made a bunch of small suggestions. FYI, if you use the "Conversation" tab then you can only implement suggestions one-by-one, but if you use the "Files changed" tab you can batch them (this is faster, IMO).

I would also like to request changing all instances of sudo cat to just cat. I can see how the sudo is useful, however we tend to leave sudo out of examples since it can be dangerous. I don't think your use is dangerous, but I'd prefer to avoid it if possible. Perhaps adding a note that sudo maybe required is nice?

book/src/advanced-datadir.md

book/src/advanced-release-candidates.md

book/src/advanced_database.md

book/src/api-bn.md

book/src/api-lighthouse.md

book/src/slasher.md

Co-authored-by: Paul Hauner <[email protected]>

chong-he · 2023-05-31T00:36:17Z

Wow, this is a big effort! It makes lots of overdue fixes and I think it's a great improvement! 🚀

I've made a bunch of small suggestions. FYI, if you use the "Conversation" tab then you can only implement suggestions one-by-one, but if you use the "Files changed" tab you can batch them (this is faster, IMO).

I would also like to request changing all instances of sudo cat to just cat. I can see how the sudo is useful, however we tend to leave sudo out of examples since it can be dangerous. I don't think your use is dangerous, but I'd prefer to avoid it if possible. Perhaps adding a note that sudo maybe required is nice?

Thanks so much for the review. I have committed all suggestions, removed comments and sudo.

paulhauner

Looks great, thank you!

paulhauner · 2023-06-01T06:38:02Z

bors r+

## Issue Addressed Update Information in Lighthouse Book ## Proposed Changes - move Validator Graffiti from Advanced Usage to Validator Management - update API response and command - some items that aren't too sure I put it in comment, which can be seen in raw/review format but not live ## Additional Info Please provide any additional information. For example, future considerations or information useful for reviewers. Co-authored-by: chonghe <[email protected]>

bors · 2023-06-01T06:41:14Z

Build failed (retrying...):

doppelganger-protection-test

## Issue Addressed Update Information in Lighthouse Book ## Proposed Changes - move Validator Graffiti from Advanced Usage to Validator Management - update API response and command - some items that aren't too sure I put it in comment, which can be seen in raw/review format but not live ## Additional Info Please provide any additional information. For example, future considerations or information useful for reviewers. Co-authored-by: chonghe <[email protected]>

bors · 2023-06-01T23:59:12Z

Build failed (retrying...):

clippy

## Issue Addressed Update Information in Lighthouse Book ## Proposed Changes - move Validator Graffiti from Advanced Usage to Validator Management - update API response and command - some items that aren't too sure I put it in comment, which can be seen in raw/review format but not live ## Additional Info Please provide any additional information. For example, future considerations or information useful for reviewers. Co-authored-by: chonghe <[email protected]>

bors · 2023-06-02T00:18:21Z

Build failed:

clippy

paulhauner · 2023-06-02T00:19:17Z

bors r-

paulhauner · 2023-06-02T00:19:44Z

bors r+

## Issue Addressed Update Information in Lighthouse Book ## Proposed Changes - move Validator Graffiti from Advanced Usage to Validator Management - update API response and command - some items that aren't too sure I put it in comment, which can be seen in raw/review format but not live ## Additional Info Please provide any additional information. For example, future considerations or information useful for reviewers. Co-authored-by: chonghe <[email protected]>

bors · 2023-06-02T00:21:10Z

Build failed (retrying...):

beacon-chain-tests

## Issue Addressed Update Information in Lighthouse Book ## Proposed Changes - move Validator Graffiti from Advanced Usage to Validator Management - update API response and command - some items that aren't too sure I put it in comment, which can be seen in raw/review format but not live ## Additional Info Please provide any additional information. For example, future considerations or information useful for reviewers. Co-authored-by: chonghe <[email protected]>

bors · 2023-06-02T00:26:14Z

Build failed (retrying...):

release-tests-ubuntu

## Issue Addressed Update Information in Lighthouse Book ## Proposed Changes - move Validator Graffiti from Advanced Usage to Validator Management - update API response and command - some items that aren't too sure I put it in comment, which can be seen in raw/review format but not live ## Additional Info Please provide any additional information. For example, future considerations or information useful for reviewers. Co-authored-by: chonghe <[email protected]>

bors · 2023-06-02T00:33:42Z

Build failed (retrying...):

beacon-chain-tests

## Issue Addressed Update Information in Lighthouse Book ## Proposed Changes - move Validator Graffiti from Advanced Usage to Validator Management - update API response and command - some items that aren't too sure I put it in comment, which can be seen in raw/review format but not live ## Additional Info Please provide any additional information. For example, future considerations or information useful for reviewers. Co-authored-by: chonghe <[email protected]>

bors · 2023-06-02T00:50:44Z

Build failed:

clippy

paulhauner · 2023-06-02T02:16:28Z

bors r+

## Issue Addressed Update Information in Lighthouse Book ## Proposed Changes - move Validator Graffiti from Advanced Usage to Validator Management - update API response and command - some items that aren't too sure I put it in comment, which can be seen in raw/review format but not live ## Additional Info Please provide any additional information. For example, future considerations or information useful for reviewers. Co-authored-by: chonghe <[email protected]>

bors · 2023-06-02T02:37:23Z

Build failed (retrying...):

execution-engine-integration-ubuntu

## Issue Addressed Update Information in Lighthouse Book ## Proposed Changes - move Validator Graffiti from Advanced Usage to Validator Management - update API response and command - some items that aren't too sure I put it in comment, which can be seen in raw/review format but not live ## Additional Info Please provide any additional information. For example, future considerations or information useful for reviewers. Co-authored-by: chonghe <[email protected]>

bors · 2023-06-02T02:44:19Z

Build failed (retrying...):

clippy

michaelsproul · 2023-06-02T03:17:10Z

bors r-
bors r+

bors · 2023-06-02T03:17:24Z

Canceled.

## Issue Addressed Update Information in Lighthouse Book ## Proposed Changes - move Validator Graffiti from Advanced Usage to Validator Management - update API response and command - some items that aren't too sure I put it in comment, which can be seen in raw/review format but not live ## Additional Info Please provide any additional information. For example, future considerations or information useful for reviewers. Co-authored-by: chonghe <[email protected]>

bors · 2023-06-02T06:00:25Z

Pull request successfully merged into unstable.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

## Issue Addressed Update Information in Lighthouse Book ## Proposed Changes - move Validator Graffiti from Advanced Usage to Validator Management - update API response and command - some items that aren't too sure I put it in comment, which can be seen in raw/review format but not live ## Additional Info Please provide any additional information. For example, future considerations or information useful for reviewers. Co-authored-by: chonghe <[email protected]>

chong-he added 4 commits May 13, 2023 13:19

Update API and Advanced

e94d061

Updates

e0c4022

Minor corrections

396fd1d

Minor correction

1ef53bc

paulhauner added the ready-for-review The code is ready for review label May 22, 2023

paulhauner self-assigned this May 22, 2023

chong-he added 4 commits May 24, 2023 07:35

update database V17

1a3ac8f

Update SPRP

e7c8701

Add example of calculation

acfeca8

Update use case

4d97257

michaelsproul added the docs Documentation label May 25, 2023

michaelsproul mentioned this pull request May 25, 2023

[Merged by Bors] - chore: Bellatrix occurred for Gnosis #4301

Closed

paulhauner requested changes May 29, 2023

View reviewed changes

paulhauner added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels May 29, 2023

chong-he and others added 4 commits May 31, 2023 07:05

Apply suggestions from code review

a9bb843

Co-authored-by: Paul Hauner <[email protected]>

Update datadir

555b526

Remove comments

1e97ab8

Remove sudo

4f2715f

chong-he and others added 2 commits May 31, 2023 09:10

Merge branch 'unstable' into book-api

a9cec0a

Minor fix

f955cfd

chong-he requested a review from paulhauner May 31, 2023 01:25

paulhauner approved these changes Jun 1, 2023

View reviewed changes

paulhauner added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jun 1, 2023

bors bot changed the title ~~Update Lighthouse Book API and Advanced Usage section~~ [Merged by Bors] - Update Lighthouse Book API and Advanced Usage section Jun 2, 2023

bors bot closed this Jun 2, 2023

chong-he deleted the book-api branch December 3, 2023 09:39

[Merged by Bors] - Update Lighthouse Book API and Advanced Usage section #4300

[Merged by Bors] - Update Lighthouse Book API and Advanced Usage section #4300

Uh oh!

Conversation

chong-he commented May 17, 2023

Issue Addressed

Proposed Changes

Additional Info

Uh oh!

paulhauner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chong-he commented May 31, 2023

Uh oh!

paulhauner left a comment

Choose a reason for hiding this comment

Uh oh!

paulhauner commented Jun 1, 2023

Uh oh!

bors bot commented Jun 1, 2023

Uh oh!

bors bot commented Jun 1, 2023

Uh oh!

bors bot commented Jun 2, 2023

Uh oh!

paulhauner commented Jun 2, 2023

Uh oh!

paulhauner commented Jun 2, 2023

Uh oh!

bors bot commented Jun 2, 2023

Uh oh!

bors bot commented Jun 2, 2023

Uh oh!

bors bot commented Jun 2, 2023

Uh oh!

bors bot commented Jun 2, 2023

Uh oh!

paulhauner commented Jun 2, 2023

Uh oh!

bors bot commented Jun 2, 2023

Uh oh!

bors bot commented Jun 2, 2023

Uh oh!

michaelsproul commented Jun 2, 2023

Uh oh!

bors bot commented Jun 2, 2023

Uh oh!

bors bot commented Jun 2, 2023

Uh oh!

Uh oh!