[Merged by Bors] - Add debug fork choice api #4003
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks @yuroitaki! It looks like there's a rustfmt failure which you can fix with |
michaelsproul
added
the
waiting-on-author
Oops I ran |
michaelsproul
added
ready-for-review
|
Thanks! Will try to give this a proper review after the current release cycle ends. We're pushing hard to release v3.5.0 with Capella support right now. |
michaelsproul
added
waiting-on-author
|
Nominating for v4.1.0 as the v4.0.0 deadline is very soon and we have a lot of other stuff to get in |
yuroitaki
force-pushed
the
fork-choice-api
branch
from
a088dcd to
f17f642
Compare
Hi @michaelsproul sorry for the delay, I've fixed the merge conflict and it should be ready now! |
michaelsproul
added
ready-for-review
michaelsproul
approved these changes
Mar 28, 2023
michaelsproul
added
ready-for-merge
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 29, 2023
## Issue Addressed Which issue # does this PR address? #3669 ## Proposed Changes Please list or describe the changes introduced by this PR. - A new API to fetch fork choice data, as specified [here](ethereum/beacon-APIs#232) - A new integration test to test the new API ## Additional Info Please provide any additional information. For example, future considerations or information useful for reviewers. - `extra_data` field specified in the beacon-API spec is not implemented, please let me know if I should instead. Co-authored-by: Michael Sproul <[email protected]>
|
Pull request successfully merged into unstable. Build succeeded:
|
bors
bot
changed the title
ghost
pushed a commit
to oone-world/lighthouse
that referenced
this pull request
Jul 13, 2023
## Issue Addressed Which issue # does this PR address? sigp#3669 ## Proposed Changes Please list or describe the changes introduced by this PR. - A new API to fetch fork choice data, as specified [here](ethereum/beacon-APIs#232) - A new integration test to test the new API ## Additional Info Please provide any additional information. For example, future considerations or information useful for reviewers. - `extra_data` field specified in the beacon-API spec is not implemented, please let me know if I should instead. Co-authored-by: Michael Sproul <[email protected]>
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
Which issue # does this PR address? sigp#3669 Please list or describe the changes introduced by this PR. - A new API to fetch fork choice data, as specified [here](ethereum/beacon-APIs#232) - A new integration test to test the new API Please provide any additional information. For example, future considerations or information useful for reviewers. - `extra_data` field specified in the beacon-API spec is not implemented, please let me know if I should instead. Co-authored-by: Michael Sproul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Which issue # does this PR address?
#3669
Proposed Changes
Please list or describe the changes introduced by this PR.
Additional Info
Please provide any additional information. For example, future considerations
or information useful for reviewers.
extra_datafield specified in the beacon-API spec is not implemented, please let me know if I should instead.