-
Notifications
You must be signed in to change notification settings - Fork 901
Support LightClientFinalityUpdate
and LightClientOptimisticUpdate
rpcs
#3849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
42245b7
add light client optimistic and finality update rpc
GeemoCandama 5d59207
Arc the updates in the response
GeemoCandama 9643686
add conditional advertisement for both LightClientOptimisticUpdate an…
GeemoCandama 9b0901c
alter display for inboundrequest light client optimistic and finality…
GeemoCandama 17e6436
remove LightClientOptimistic/FinalityReuest struct and some minor fixes
GeemoCandama ddf0874
rebase
GeemoCandama 29bfdb8
failing rpc_test for LightClientBootstrap and beginning of MockLib2pL…
GeemoCandama e6c4c72
minor change
GeemoCandama 5620c74
added MockRPCHandler by importing everything except OutboundRequest. …
GeemoCandama 520962f
almost there but ran into issue where needed to implement BaseOutboun…
GeemoCandama 68d43d5
failing but running with a light client service of sorts
GeemoCandama cf4a24c
small test change
GeemoCandama 555bf46
changed Protocol::LightClientBootstrap response limit
GeemoCandama d5ae43d
deleted some stuff from ConnectionHandler Implementation for the mock…
GeemoCandama 2a6299a
deleted purging expired inbound/outbound streams code
GeemoCandama d7cdae1
deleted drive inbound streams that need to be processed
GeemoCandama 909c34c
removed unused imports
GeemoCandama 194d8d3
made things private again
GeemoCandama 9abc31e
deleted inject_fully_negotiated_inbound
GeemoCandama 81ba801
made more things private again
GeemoCandama 4c41643
more
GeemoCandama f55977f
turned the logger off in the test
GeemoCandama f7371e2
added failing test for new rpc
GeemoCandama 5027b83
add rate limit for new rpcs
GeemoCandama 8226f05
change InboundUpgrade function to use new rpcs. fmt. add test for Lig…
GeemoCandama 474d512
rebasing fix
GeemoCandama 86aa148
add LightClientUpdate to handle_rpc functions
GeemoCandama 3f7c8c2
added context bytes
GeemoCandama 55a4596
fmt
GeemoCandama 8ffd209
use correct unsed_tcp4_port function
GeemoCandama c9fa08f
fix for recent config changes and adding context_bytes for the light …
GeemoCandama 691f688
fix clippy complaint
GeemoCandama 64dac1b
Merge branch 'unstable' into lc-reqresp
jimmygchen 38a029a
Error handling updates and various cleanups.
jimmygchen 9b5d14f
Moar minor clean ups.
jimmygchen e5f9738
Do not ban peer for rate limiting light client requests
jimmygchen 8e72d38
Merge branch 'unstable' into lc-reqresp. Also removed the mock light …
jimmygchen a610e2a
Remove unnecessary changes
jimmygchen 8d3b26f
Add missing light client queue handling.
jimmygchen e393bf3
Merge branch 'unstable' into lc-reqresp
jimmygchen 8015b2d
Merge branch 'unstable' into lc-reqresp
jimmygchen 2e8ccbb
Add context bytes for light client RPC responses.
jimmygchen c888923
Add RPC limits for light client object.
jimmygchen bd167fa
Fix lint
jimmygchen 00144af
Fix incorrect light client max size computation.
jimmygchen 50c463d
Merge branch 'unstable' into lc-reqresp
jimmygchen 08ed69e
Remove unwanted local changes.
jimmygchen 1df31be
Merge branch 'unstable' into lc-reqresp
jimmygchen 51fe0ce
Replace `unimplemented` electra code path with deneb values.
jimmygchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not default to Deneb for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the Electra changes to light clients, and I'd rather not forget to update this when Electra comes. What's the value of adding a value that might be obsolete? We're not going to hit this code path pre Electra.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worry we forget, enable the light-client server by default and LH gets panics on devnets / testnets. Could add a default to electra and a
TODO(electra)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 51fe0ce