Add support for OSC52 clipboard codes for the REPL .copy command. #1280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigoden
reviewed
May 5, 2025
src/utils/clipboard.rs
Outdated
| } | ||
|
|
||
| #[cfg(any(target_os = "android", target_os = "emscripten"))] | ||
| pub fn set_text(_text: &str) -> anyhow::Result<()> { | ||
| Err(anyhow::anyhow!("No clipboard available").context("Failed to copy")) | ||
| pub fn set_text(text: &str) -> Result<()> { |
There was a problem hiding this comment.
- This function must return
anyhow::Result, otherwise it will cause a compilation error.
-pub fn set_text(text: &str) -> Result<()> {
+pub fn set_text(text: &str) -> anyhow::Result<()> {- Even in Android or WASM environments, OSC52 clipboard support is unlikely. I suggest leaving the function as it is.
|
@gcv Thank you for your contribution. OSC52 clipboard code support is definitely necessary. However, there are a few minor issues; would you have time to fix them? |
|
Yes, I’ll fix those. I’m surprised I didn’t get compilation errors with that namespace problem. Edit: Probably because it’s conditionally compiled. |
|
I reversed the changes to the function handling unsupported platforms. Thanks for the code review! |
|
@gcv please fix clippy error https://github.com/sigoden/aichat/actions/runs/14840017582/job/41713010102?pr=1280 |
|
Clippy warnings fixed in the latest commit. |
|
Formatting fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.copyREPL command does not work when aichat runs on a headless server. It appears that the arboard crate only works with graphical Linux interfaces, X11 and Wayland. When these are not available, it fails. This PR adds a fallback to use an OSC52 terminal codes to access the clipboard through the terminal emulator. This works on pretty much all modern emulators. Seems to work on my testing, and seems to work correctly under X11 (I don’t have a Wayland system to test with).Thanks for this excellent package! aichat is the best CLI/TUI LLM interface I found, and I use it every day.