Fix use extra tools in agent mode #1252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramosc
force-pushed
the
fix/extra-tools-agent
branch
from
3d534de to
0742796
Compare
|
@cramosc |
Currently when using extra tools added either via ``` .set use_tools some_tool ``` or the agent config yaml ``` use_tools: some_tool ``` these tools cannot be used when in agent mode. The reason is that the `ToolCall::eval` method only looks inside the tools defined inside the agent `agent.functions()` and when not found it returns an error instead of looking into the config's `use_tools`
cramosc
force-pushed
the
fix/extra-tools-agent
branch
from
0742796 to
9571f08
Compare
oops sorry. Removed |
dbroeglin
pushed a commit
to dbroeglin/aichat
that referenced
this pull request
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using extra tools added either via
or the agent config yaml
these tools cannot be used when in agent mode. The reason is that the
ToolCall::evalmethod only looks inside the tools defined inside the agentagent.functions()and when not found it returns an error instead of looking into the config'suse_tools