get_album: prevent KeyError when parsing missing artist data #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`get_album` no longer errors on albums with no artist metadata, instead returning `"artist": None`
sgvictorino
force-pushed
the
optional-artist-header
branch
from
f1ad93d to
f03ce7f
Compare
|
Thank you! I will need to take some time tonight to fix the failing tests. Probably some entities were removed on the server |
sigma67
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #788 +/- ##
=======================================
Coverage 93.99% 94.00%
=======================================
Files 43 43
Lines 2499 2500 +1
=======================================
+ Hits 2349 2350 +1
Misses 150 150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kaneryu
pushed a commit
to kaneryu/ytmusicapi
that referenced
this pull request
Aug 27, 2025
`get_album` no longer errors on albums with no artist metadata, instead returning `"artist": None` Co-authored-by: sigma67 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #786
get_albumno longer errors on albums with no artist metadata, instead returning"artist": None