Skip to content

Conversation

@minzunim
Copy link
Contributor

@minzunim minzunim commented Sep 6, 2025

fix(types): restrict StreamOptions.objectMode to true

As discussed in #3686, objectMode is always forced to true internally, so the current any type is misleading. This change updates the definition to true to better reflect the actual behavior.

Closes #3686

@codecov
Copy link

codecov bot commented Sep 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.25%. Comparing base (aac1b0f) to head (585829b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3784   +/-   ##
=======================================
  Coverage   89.25%   89.25%           
=======================================
  Files          86       86           
  Lines       13583    13583           
  Branches     1584     1584           
=======================================
  Hits        12124    12124           
  Misses       1459     1459           
Flag Coverage Δ
compression-0 88.36% <ø> (ø)
compression-1 89.23% <ø> (ø)
static-parser-0 86.82% <ø> (ø)
static-parser-1 87.59% <ø> (ø)
tls-0 88.67% <ø> (ø)
tls-1 89.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wellwelwel wellwelwel merged commit c091f1b into sidorares:master Sep 8, 2025
123 of 124 checks passed
@wellwelwel
Copy link
Collaborator

Thanks, @minzunim! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Query StreamOptions.objectMode has type any, should be true

2 participants