Revert <wa-code-demo>
in docs
#981
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
<wa-code-demo>
component is marked as experimental but it's way too opinionated and messy for a stable candidate. It was an opportunistic addition that was added hastily and it's made it more difficult to fix things like #680 due to the abstracted logic.It also introduced problems with
<wa-popup>
being clipped/sized problematically in various demos like dropdown, select, and other popup-related components.There may be value in such a component at some point, but at the moment it's easier to revert to the old behavior and inline the examples.
@lindsaym-fa I brought back the original resizer and made it even better than the tiny handle we have now.
CleanShot.2025-05-21.at.16.32.48.mp4
This PR also fixes #680.
TODO
<wa-page>
docs are borked because they're not isolated anymore. I may move these to separate windows unless @KonnorRogers has another idea for them.Note: There are some spacing issues in various places as a result of this change, which appear to be from the ridiculously high specificity of the native style selectors, so most of that should be fixed with #943 and the addition of CSS layers., e.g.:
