Skip to content

Conversation

claviska
Copy link
Member

@claviska claviska commented May 21, 2025

The <wa-code-demo> component is marked as experimental but it's way too opinionated and messy for a stable candidate. It was an opportunistic addition that was added hastily and it's made it more difficult to fix things like #680 due to the abstracted logic.

It also introduced problems with <wa-popup> being clipped/sized problematically in various demos like dropdown, select, and other popup-related components.

There may be value in such a component at some point, but at the moment it's easier to revert to the old behavior and inline the examples.

@lindsaym-fa I brought back the original resizer and made it even better than the tiny handle we have now.

CleanShot.2025-05-21.at.16.32.48.mp4

This PR also fixes #680.


TODO

  • The <wa-page> docs are borked because they're not isolated anymore. I may move these to separate windows unless @KonnorRogers has another idea for them.
  • Normalize a handful of camelCased filenames
  • Review remaining docs to ensure everything is working as expected

Note: There are some spacing issues in various places as a result of this change, which appear to be from the ridiculously high specificity of the native style selectors, so most of that should be fixed with #943 and the addition of CSS layers., e.g.:
Image

@claviska claviska added this to the Beta Release milestone May 21, 2025
@claviska claviska self-assigned this May 21, 2025
@claviska claviska added documentation Improvements or additions to documentation biggun This one's a biggun (e.g. requires a larger undertaking or touches a lot of files) labels May 21, 2025
Copy link

vercel bot commented May 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webawesome ✅ Ready (Inspect) Visit Preview May 22, 2025 5:42pm

@claviska
Copy link
Member Author

I fixed the <wa-page> docs by breaking out the two demos into separate HTML files. This works nicely, as the user can view and inspect full-sized pages now.

@claviska claviska marked this pull request as ready for review May 22, 2025 11:46
@claviska claviska changed the title remove code demo Revert <wa-code-demo> May 22, 2025
@claviska claviska changed the title Revert <wa-code-demo> Revert <wa-code-demo> in docs May 22, 2025
@claviska claviska merged commit 4e14f25 into next May 23, 2025
2 checks passed
@claviska claviska mentioned this pull request May 27, 2025
@claviska claviska deleted the without-code-demo branch August 21, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
biggun This one's a biggun (e.g. requires a larger undertaking or touches a lot of files) documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FA Pro icons not showing in CodePen examples
1 participant