updated card slot from image to media
#975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| display: flex; | ||
|
|
||
| &::slotted(img) { | ||
| &::slotted(*) { |
There was a problem hiding this comment.
I worry if using the wildcard here is too generic and needs to be more specific
There was a problem hiding this comment.
oh weird this came in right as I posted this! haha #975 (comment)
There was a problem hiding this comment.
That said, if you think it's too generic, I'm fine with limiting it to certain elements!
claviska
previously approved these changes
May 21, 2025
| display: flex; | ||
|
|
||
| &::slotted(img) { | ||
| &::slotted(*) { |
There was a problem hiding this comment.
At first, I wasn't sure if this was too eager and should be scoped down to img, video, and iframe but it is called the "media" slot, so I actually think it's fine as-is.
claviska
changed the title
image to media
|
@kelseythejackson oh this one thing this needs a line in the changelog :) |
claviska
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #535.
It changes the
imageslot in the card component tomedia. It's broader and more appropriate.