-
Notifications
You must be signed in to change notification settings - Fork 38
Revisit bright
palette accents, closes #697
#705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This is overall fantastic work @lindsaym-fa! And yes, I agree that you started from the toughest one. Hardcore! 😬
If it helps, I don’t think we need to stick within the sRGB gamut, P3 is fine. Even in the worst case, clipping instead of gamut mapping on an sRGB screen, the distance is small enough that it's usually okay.
The rest are dope 🚀 |
I'm inclined to agree. Admittedly, These two colors are used pretty extensively on fontawesome.com, so I'd like to keep them somewhat true to what's in use now. @LeaVerou, if you don't mind, it might be helpful to know the general hue ranges for indigo, purple, and pink in other scales. I'll also reach out to some FA folks to see what they think. I'll tweak |
We don't have pink yet. Do you mean other color palettes, not Web Awesome’s? If so, that's actually already computed at https://palettes.colorjs.io/ ! Looking those ranges:
So that’s nice, they don't overlap like I feared. And yes, according to those, this palette’s I can compute the hue ranges based on our other palettes if that would be helpful. |
Adjusted @LeaVerou, let me know if this feels better! |
Because this palette has the unique goal of supporting Font Awesome's current color usage, I suspect this palette will be the toughest to get just right. So, I've started here. 😊
Key changes:
bright
moniker (itself inspired by FA's usage), accent colors occur at tints lighter than50
(gray
being an intentional exception to keep FA's concept of "gravy", where dark grays skew towards navy blue)yellow
less towards red/orange to make way for Addorange
#657gray
so that it actually occurs at40
(the clamped value) instead of20
teal
withcyan
, fixes #659 #671 so thatawesome.css
usesgreen
forsuccess
instead ofcyan
Before
After
Observations
When we get to using tintless colors in #220, I suspect we'll still want
--wa-color-danger-fill-loud
inawesome.css
to use--wa-color-red-70
instead of the true core color,60
. Chroma is at its max (within sRGB gamut) for--wa-color-red-70
, but because chroma is relatively low for reds at this lightness,¹ forcing less chroma for60
and beyond has...well, not great results.²At the same time,
60
feels a bit too strong to use alongside the other core colors, which sit at70
or80
. Plus,70
is a closer match to Font Awesome's oft-used red.³¹ Chroma chart from Evil Martians' OKLCH color picker

² Very sad reds. 😢

³ As seen on fontawesome.com
