Skip to content

Add breaks between radios in Radio Group examples #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

lindsaym-fa
Copy link
Contributor

Fixes some unsightliness in the Radio Group docs by adding breaks between <wa-radio>s in the examples.

Before:
Screenshot 2025-01-24 at 1 57 12 PM

After:
Screenshot 2025-01-24 at 1 56 53 PM

As a more substantial improvement, I'd love to offer some layout options for <wa-radio-group> to arrange the controls within either vertically or horizontally with reasonable default gaps that can be overridden, but that might be best considered following #504.

Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webawesome ✅ Ready (Inspect) Visit Preview Jan 24, 2025 7:04pm

@lindsaym-fa lindsaym-fa requested a review from claviska January 24, 2025 19:04
@claviska
Copy link
Member

@lindsaym-fa break do you think we should wrap the default slot with a flex container, add a gap, and add an orientation attribute that sets flex-direction? Or did you have another idea?

This is fine to merge in the meantime :)

@LeaVerou
Copy link
Contributor

As a more substantial improvement, I'd love to offer some layout options for <wa-radio-group> to arrange the controls within either vertically or horizontally with reasonable default gaps that can be overridden, but that might be best considered following #504.

Ha, I just suggested orientation for radio-group in #504 without having seen this! And yes, it should probably default to vertical.

@lindsaym-fa
Copy link
Contributor Author

do you think we should wrap the default slot with a flex container, add a gap, and add an orientation attribute that sets flex-direction? Or did you have another idea?

@claviska That's exactly what I was thinking. How we allow folks to override the gap was the only thing stalling me, but now that I've stepped away from it, I realize that targeting ::part(form-control-input) would probably work just fine.

@lindsaym-fa lindsaym-fa merged commit 815cc42 into next Jan 24, 2025
2 checks passed
@LeaVerou
Copy link
Contributor

Why not just setting gap on radio-group? That seems to be the most straightforward option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants