-
Notifications
You must be signed in to change notification settings - Fork 39
Tintless variables + OKLCH coords as comments #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, @LeaVerou — thank you. 🙇 It will be a huge help for refining our palettes!
I believe the answer to this is 'no', but I want to ask to be absolutely certain: Is there any tintless.js
maintenance necessary if we either add more palettes or add/change hues (e.g., add orange
, change teal
> cyan
)?
Co-authored-by: Lindsay M <[email protected]>
Yup! The only thing we may need to adjust for certain hues is the terminal output colors if we want to get nice output colors that chalk doesn't already support, but that's not essential. |
@claviska any ideas why the tests are failing? I tried re-running them, no avail. It seems it's related to Prettier, but I can't figure out what is bothering it. |
Yup, I saw that, but I can't figure out what the issue is 🤔 |
Oh I see, there's an extra space! 😵💫 Okay, that's an easy fix. |
This PR adds:
--wa-color-blue
). Closes Add "tintless" color variables to hold the key/accent color for each palette (--color-foo
, not just--color-foo-XX
) #220Current output:

Sample code:

Currently out of scope (but that can change):
--wa-color-blue-key: 50
)I also haven't updated the docs yet, we can do that separately.