-
Notifications
You must be signed in to change notification settings - Fork 36
Separate meaningful theme parts out #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly there. I fixed up a few misplaced properties, but there seems to be an issue with the Component Group properties not being applied in dark mode.
For example, here's a Premium switch in light mode:
And here's the same switch in dark mode (note the color and smaller size):
Compare this to a Premium switch in dark mode on next
, which has the intended appearance:
Oh, I know what is causing this. It's an easy fix, will ping you when it's time to re-review. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That (mostly) fixed it, thanks!
Our good friend Safari is ignoring any colors set for the component group tokens in dark mode. 🤦 I've approved this anyway; we can make another issue and investigate separately since it's a fairly minor problem.
For example, a Brutalist switch in dark mode in Chrome (expected):
...and a Brutalist switch in dark mode in Safari (unexpected):
An Awesome input in dark mode in Chrome (expected):
An Awesome input in dark mode in Safari (unexpected):
sigh
That's so strange. I have a theory: I wonder if it's related to support for |
Surprisingly, no. Just Safari. |
So weird. Anyhow, I'm confident we can fix it, and the longer this sits, the harder it will get to merge, so I'm going to go ahead and merge this, then debug. |
.wa-palette-*
classes to each color paletteHaven't done Gl[ao]ssy and Playful to not conflict with @lindsaym-fa's work.