Remove custom properties that are easily styled with CSS parts #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The only necessary remaining work here is to fix any theme overrides that may have been targeting the removed custom properties. Because #1048 implements a number of changes to those theme stylesheets, I'll wait until that PR merges before I pursue those fixes. |
claviska
approved these changes
Jun 27, 2025
claviska
approved these changes
Jun 27, 2025
…ttps://github.com/shoelace-style/webawesome into lm/superfluous-custom-properties-are-not-so-super
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work removes a majority of custom properties we had previously added to components in favor of prioritizing styling via
::part()selectors.To this end, this PR also eliminates
styles/utilities/appearance.cssin favor of including the relevant appearances within each component's own styles. This makes it much easier to track and understand where certain styles are being set.