Skip to content

Rework setting initial values in <wa-select> #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 23, 2025

Conversation

KonnorRogers
Copy link
Collaborator

@KonnorRogers KonnorRogers commented Jun 20, 2025

TODO

  • Update select
  • Update docs

Copy link

vercel bot commented Jun 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webawesome ✅ Ready (Inspect) Visit Preview Jun 23, 2025 4:32pm

@claviska claviska marked this pull request as draft June 20, 2025 15:37
@claviska
Copy link
Member

@KonnorRogers Is this something I can take over or should I wait for you?

@KonnorRogers
Copy link
Collaborator Author

@claviska you're more than welcome to take it over. I think it covers most of the edge cases. Documentation does need to be updated, tests fixed, and remove the top example I was using for testing. So totally up to you how you want to handle it. You can always merge it and we can fix it later.

@claviska claviska marked this pull request as ready for review June 23, 2025 16:45
@claviska claviska changed the title [DRAFT]: fix select to use selected options Fix select to use selected options Jun 23, 2025
@claviska claviska changed the title Fix select to use selected options Rework setting initial values in <wa-select> Jun 23, 2025
@claviska claviska merged commit c11d612 into next Jun 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants