Improve rating's default a11y #1019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claviska
added
accessibility
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Lindsay M <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out, we do have an outlined star in FA free. 😆
This PR improves the default contrast of rating, making it more accessible by showing a darker outline for inactive stars and the same solid yellow for active ones.
An
isSelectedargument was added togetSymbol()to allow us (and users) to hook into it. The docs have been updated as well.@lindsaym-fa I had to use
--wa-color-neutral-border-loudfor the outline, as the fills weren't dark enough. Let me know if there's a better token for this.Before:
After:
Fixes #429