feat(api): Introduce BuildExecutor for multiple runner kinds #1956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
openshift-ci
bot
added
the
do-not-merge/release-note-label-needed
adambkaplan
reviewed
Aug 4, 2025
There was a problem hiding this comment.
General 👍 to the sprit of this PR. I agree with @SaschaSchwarze0 that we probably should get agreement field name in status before merging this.
Note that because this PR marks a field as deprecated, we probably need to add comments that instruct the linter to skip specific lines that reference the "old" status fields.
openshift-merge-robot
added
the
needs-rebase
feat(api): Introduce BuildExecutor for multiple runner kinds This commit introduces a new BuildExecutor field to the BuildRunStatus to define the resource responsible for executing a build. This change allows for supporting different kinds of runners, such as TaskRun and PipelineRun. The new BuildExecutor struct contains two fields: Name: The name of the runner resource (e.g., the TaskRun or PipelineRun name). Kind: The kind of the runner resource (e.g., "TaskRun", "PipelineRun"). With this change, the TaskRunName field is now deprecated. Conversion Logic: v1beta1 → v1alpha1: The ImageBuildRun.Name is mapped to the LatestTaskRunRef field in v1alpha1. If ImageBuildRun is not present, it falls back to the deprecated TaskRunName field. The Kind information is not passed, as v1alpha1 only supports TaskRuns. v1alpha1 → v1beta1: The LatestTaskRunRef from v1alpha1 is mapped to ImageBuildRun.Name. ImageBuildRun.Kind is defaulted to "TaskRun" for compatibility. Added `// nolint:staticcheck` a directive to disable a specific linter check for a particular line or block of code. :staticcheck: This specifies the name of the linter to disable. staticcheck is a popular Go linter that performs a wide variety of static analysis checks. Signed-off-by: Hasan Awad <[email protected]>
hasanawad94
force-pushed
the
buildrun-type
branch
from
2a63909 to
50b9dac
Compare
hasanawad94
changed the title
openshift-merge-robot
removed
the
needs-rebase
hasanawad94
force-pushed
the
buildrun-type
branch
from
f8a0ab6 to
40c205b
Compare
|
/release-note |
|
@hasanawad94: the In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
release-note
hasanawad94
force-pushed
the
buildrun-type
branch
from
40c205b to
d4bdf5d
Compare
SaschaSchwarze0
added
the
kind/api-change
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
1 task
hasanawad94
pushed a commit
to hasanawad94/build
that referenced
this pull request
Aug 19, 2025
feat(api): Introduce BuildExecutor for multiple runner kinds
1 task
4 tasks
hasanawad94
added a commit
to hasanawad94/community
that referenced
this pull request
Sep 11, 2025
Explination of the Executor field which was added in shipwright-io/build#1956. Executor field defines the resource responsible for executing a build. Signed-off-by: Hasan Awad <[email protected]>
4 tasks
hasanawad94
added a commit
to hasanawad94/community
that referenced
this pull request
Sep 14, 2025
Explination of the Executor field which was added in shipwright-io/build#1956. Executor field defines the resource responsible for executing a build. Signed-off-by: Hasan Awad <[email protected]>
hasanawad94
added a commit
to hasanawad94/community
that referenced
this pull request
Sep 14, 2025
Explination of the Executor field which was added in shipwright-io/build#1956. Executor field defines the resource responsible for executing a build. Signed-off-by: Hasan Awad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new BuildExecutor field to the BuildRunStatus to define the resource responsible for executing a build. This change allows for supporting different kinds of runners, such as TaskRun and PipelineRun.
Relevant to #1924
Changes
BuildExecutor struct contains two fields:
Added
Deprecatedto the TaskRunName field.Conversion Logic:
v1beta1 → v1alpha1:
The ImageBuildRun.Name is mapped to the LatestTaskRunRef field in v1alpha1. If ImageBuildRun is not present, it falls back to the deprecated TaskRunName field. The Kind information is not passed, as v1alpha1 only supports TaskRuns. v1alpha1 → v1beta1:
The LatestTaskRunRef from v1alpha1 is mapped to ImageBuildRun.Name. ImageBuildRun.Kind is defaulted to "TaskRun" for compatibility.
Added
// nolint:staticchecka directive to disable a specific linter check for a particular line or block of code.Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes