Skip to content

Conversation

9romise
Copy link
Contributor

@9romise 9romise commented Aug 25, 2025

Description

This PR makes it more convenient for users to modify existing themes.

Important

One thing to note: I've changed the theme option to themes to align with upstream naming. This is a breaking change, so if you prefer, I can move this adjustment to a separate PR. Just let me know!

Linked Issues

Related: vueuse/vueuse#4983

Additional context

Copy link

netlify bot commented Aug 25, 2025

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit b99c167
🔍 Latest deploy log https://app.netlify.com/projects/shiki-matsu/deploys/68ac3f1ac0e64b000832671e
😎 Deploy Preview https://deploy-preview-1066--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Aug 25, 2025

Deploy Preview for shiki-next ready!

Name Link
🔨 Latest commit b99c167
🔍 Latest deploy log https://app.netlify.com/projects/shiki-next/deploys/68ac3f1a9bcb9b000818bf26
😎 Deploy Preview https://deploy-preview-1066--shiki-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@antfu
Copy link
Member

antfu commented Aug 25, 2025

Is it possible to keep backward compatibilty and mark it as deprecated?

Copy link

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.41%. Comparing base (d05f39b) to head (b99c167).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1066   +/-   ##
=======================================
  Coverage   95.41%   95.41%           
=======================================
  Files          89       89           
  Lines        7576     7576           
  Branches     1593     1593           
=======================================
  Hits         7229     7229           
  Misses        341      341           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@9romise
Copy link
Contributor Author

9romise commented Aug 25, 2025

The option type (FloatingVueConfig) is any, and it's from upstream. Maybe I should also contribute to it for the better type.

@9romise 9romise changed the title feat(vitepress-twoslash)!: improve UX for option customization feat(vitepress-twoslash): improve UX for option customization Aug 25, 2025
@antfu antfu merged commit e3cfdec into shikijs:main Aug 27, 2025
14 checks passed
@9romise 9romise deleted the client/fix-options branch August 27, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants