-
-
Notifications
You must be signed in to change notification settings - Fork 467
feat(vitepress-twoslash): improve UX for option customization #1066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for shiki-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Is it possible to keep backward compatibilty and mark it as deprecated? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1066 +/- ##
=======================================
Coverage 95.41% 95.41%
=======================================
Files 89 89
Lines 7576 7576
Branches 1593 1593
=======================================
Hits 7229 7229
Misses 341 341
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The option type ( |
Description
This PR makes it more convenient for users to modify existing themes.
Important
One thing to note: I've changed the
theme
option tothemes
to align with upstream naming. This is a breaking change, so if you prefer, I can move this adjustment to a separate PR. Just let me know!Linked Issues
Related: vueuse/vueuse#4983
Additional context