feat: add funding buttons to themes & languages list #1052
Merged
+95
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for shiki-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jtbandes
commented
Aug 4, 2025
Comment on lines
+13
to
+14
| const allThemes = shallowRef<ThemeInfo[]>([]) | ||
| const allLanguages = shallowRef<GrammarInfo[]>([]) |
There was a problem hiding this comment.
Is it okay to leave these empty? Since I changed the type it was harder to include some default values.
Comment on lines
+19
to
+20
| "tm-grammars": "catalog:inlined", | ||
| "tm-themes": "catalog:inlined", |
There was a problem hiding this comment.
is this catalog import ok?
This was referenced Aug 5, 2025
This was referenced Aug 27, 2025
1 task
1 task
This was referenced Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Towards #906:
tm-grammars/tm-themesinstead ofshiki/bundle/{web,full}. As discussed in Display funding/sponsor links for grammars and themes? #906 (comment), the shiki bundle does not include funding info and it's not necessary to increase the bundle size by adding it there when the same information is available from the other packages.Linked Issues