feat: allow negative character positions for denoting end of line offsets #1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for shiki-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
antfu
approved these changes
Aug 4, 2025
3 tasks
1 task
This was referenced Aug 27, 2025
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it easy to highlight entire lines without needing to know their lengths. This is achieved by allowing negative character positions in
OffsetOrPosition: -1 denotes the end of the line, -2 is the character before, etc.Linked Issues
#1038
Additional context
Sometimes, you have line numbers that you want to highlight or transform. This change means that applications using Shiki will not need to do manual line length calculations, which Shiki already does.
This is my first contribution to the project. Maintainers, feel free to make edits, and I'd be happy to make changes as needed. I added an additional test case to the transformer tests which covers this change.