Skip to content

Skip ReadOnly and BindIgnore Properties on Bind #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shibayan merged 1 commit into from
Aug 26, 2022
Merged

Skip ReadOnly and BindIgnore Properties on Bind #228

shibayan merged 1 commit into from
Aug 26, 2022

Conversation

@rodrigopiccelli
Copy link
Contributor

@rodrigopiccelli rodrigopiccelli commented Aug 24, 2022 •
edited
Loading

  • Fix an issue when you try to bind a class with read-only properties
  • Introduce BindIgnoreAttribute to ignore properties for binding

shibayan
shibayan reviewed Aug 24, 2022
View reviewed changes
Copy link
Owner

@shibayan shibayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great fix, I commented on one point.

@rodrigopiccelli rodrigopiccelli marked this pull request as draft August 24, 2022 14:22
@rodrigopiccelli rodrigopiccelli changed the title Skip ReadOnly and AutoGenerated Properties on Bind Skip ReadOnly and BindIgnore Properties on Bind Aug 24, 2022
@rodrigopiccelli rodrigopiccelli marked this pull request as ready for review August 24, 2022 14:48
@rodrigopiccelli
Skip ReadOnly and BindIgnore Properties on Bind
adf3636 
- Skip ReadOnly properties on Bind
- Introduce BindIgnoreAttribute to ignore properties for binding
- Adds ReadOnly sample
- Adds BindIgnore sample
- Adds UnitTests for ReadOnly and BindIgnoreAttribute
shibayan
shibayan approved these changes Aug 26, 2022
View reviewed changes
Copy link
Owner

@shibayan shibayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@shibayan shibayan merged commit a3c8360 into shibayan:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shibayan shibayan shibayan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rodrigopiccelli @shibayan