Adds range syntax for line highlights #809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
requested changes
Jan 26, 2020
Owner
sharkdp
left a comment
sharkdp
left a comment
There was a problem hiding this comment.
Great, thank you very much!
I have a few minor comments.
src/bin/bat/clap_app.rs
Outdated
| '--highlight-line 30:40' highlights lines 30 to 40\n \ | ||
| '--highlight-line :40' highlights lines 1 to 40\n \ | ||
| '--highlight-line 40:' highlights lines 40 to the end of the file\n \ | ||
| '--highlight-line 40' highlights only line 40", |
Owner
There was a problem hiding this comment.
Can we please move this example to the top? Also, highlights only line 40 => highlight line 40
src/bin/bat/clap_app.rs
Outdated
| '--line-range :40' prints lines 1 to 40\n \ | ||
| '--line-range 40:' prints lines 40 to the end of the file", | ||
| '--line-range 40:' prints lines 40 to the end of the file\n \ | ||
| '--line-range 40' prints only line 40", |
src/line_range.rs
Outdated
| new_range.upper = line_numbers[1].parse()?; | ||
| Ok(new_range) | ||
| }, | ||
| _ => Err("expected at most single ':' character".into()), |
Owner
There was a problem hiding this comment.
Can we change this error message to:
Line range contained more than one ':' character. Expected format: 'N' or 'N:M'.
Owner
|
Thank you |
sharkdp
approved these changes
Jan 27, 2020
Owner
|
This has been released in bat 0.13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--highlight-linenow accepts line ranges like the--line-rangeoption.