Skip to content

Conversation

@connorjs
Copy link
Contributor

Removes duplicate winget instructions for Windows install.

Removes duplicate winget instructions for Windows install.
@Enselic
Copy link
Collaborator

Enselic commented Sep 29, 2023

Oops! I and @sharkdp merged different versions (#2519, #2594) at the same time, and never noticed the accidental duplication.

Let's keep this version though. It is shorter, and I like short. Or are there good reasons to keep the other one?

Thanks!

@connorjs
Copy link
Contributor Author

connorjs commented Sep 29, 2023

The difference lies in preference for -e (exact). The important part is that it’s already qualified (not just bat), so I’m happy to keep either given your preference.

I always use -e --id, but personal preference to avoid typos when not copying.

@connorjs
Copy link
Contributor Author

Switched to shorter one, but kept it in the first position (for Windows) + “WinGet” casing. I generally see WinGet, Choco, and Scoop as the order.

Copy link
Collaborator

@Enselic Enselic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Enselic Enselic merged commit 69c326f into sharkdp:master Sep 29, 2023
@connorjs connorjs deleted the patch-1 branch September 29, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants