Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 1, 2021

Bumps assets/syntaxes/02_Extra/SCSS_Sass from 63819a1 to 48de9e3.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [assets/syntaxes/02_Extra/SCSS_Sass](https://github.com/braver/SublimeSass) from `63819a1` to `48de9e3`.
- [Release notes](https://github.com/braver/SublimeSass/releases)
- [Commits](SublimeText/Sass@63819a1...48de9e3)

---
updated-dependencies:
- dependency-name: assets/syntaxes/02_Extra/SCSS_Sass
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code labels Jul 1, 2021
@keith-hall
Copy link
Collaborator

It looks like this currently fails because it changes some colors of CSS units like px from a keyword to just a number color, which mirrors the core CSS changes (https://github.com/sublimehq/Packages/pull/2517/files). So I think we should consider some color scheme patches to "correct" this.
If this was all, I would consider merging, but it also now fails to parse some comments correctly it seems and instead colors the /* as operators and the contents as though they are not comments. But it might not be a bug in the Sass/SCSS syntaxes, it may be something in syntect not supported, or perhaps because we would need to upgrade our CSS syntax definition too... Needs more investigation... :)

@sharkdp
Copy link
Owner

sharkdp commented Jul 25, 2021

It looks like this currently fails because it changes some colors of CSS units like px from a keyword to just a number color, which mirrors the core CSS changes (https://github.com/sublimehq/Packages/pull/2517/files). So I think we should consider some color scheme patches to "correct" this.

In such a scenario (when the new output is an improved version of the old one), I would hope that re-generating the highlighted/ files via tests/syntax-tests/update.sh would be enough?

@sharkdp
Copy link
Owner

sharkdp commented Jul 25, 2021

If this was all, I would consider merging, but it also now fails to parse some comments correctly it seems and instead colors the /* as operators and the contents as though they are not comments. But it might not be a bug in the Sass/SCSS syntaxes, it may be something in syntect not supported, or perhaps because we would need to upgrade our CSS syntax definition too... Needs more investigation... :)

I'm not 100% sure we can trust the colorized output in GitHub actions. Maybe we should run this locally to make sure.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 1, 2021

Superseded by #1766.

@dependabot dependabot bot closed this Aug 1, 2021
@dependabot dependabot bot deleted the dependabot/submodules/assets/syntaxes/02_Extra/SCSS_Sass-48de9e3 branch August 1, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants