Add syntax highlighting for SML (Standard ML) #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted from https://github.com/seanjames777/SML-Language-Definition/blob/master/sml.tmLanguage and removed `ml` filetype to fix an (assumed) possible conflict with existing OCaml support.
Owner
|
Thank you for your contribution.
👍 This would have been caught by a unit test otherwise: |
Owner
|
Released in bat v0.15.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntax:
This PR adds syntax highlighting support for SML (Standard ML).
Guideline Criteria:
https://packagecontrol.io/packages/SML%20(Standard%20ML) (16k installs)
Notes:
The upstream syntax was originally in
tmLanguageformat, which I've converted to a.sublime-syntaxfile, along with removingmlas a filetype that it attempts to highlight as it's my understanding that this could conflict with existing rules for OCaml. As such, I've not included it as a submodule, though if this is undesirable, I can amend as necessary.