trimOnSave doesn't work

[pewscorner]

The extension is failing so badly that it is completely unusable for me. I'm using these non-default settings:

"trailing-spaces.trimOnSave": true,
"trailing-spaces.deleteModifiedLinesOnly": true,

When I save a file, I expect the extension to remove all trailing spaces on lines modified since the last save. And I expect the spaces to be removed immediately before the file is saved, so the end result is actually saved.

However, what actually happens is that trailing spaces in very few (sometimes none) of the modified lines are trimmed. And the trimming happens after the save, so I have to save again to save the trimmed result.

Steps to reproduce:

1. Create a new file with 'a' on the 1st line, 'b' on the 2nd, and nothing on the 3rd, and save this file.
2. Add a space at the end of each of the first 2 lines, and place the cursor on the 3rd line.
3. Save the file.
   Most frequent result: The file is saved without any trimming (verify this with another editor), then the space on the 1st line - but not the 2nd - is removed, and the editor is now in "unsaved" state. I was expecting both spaces to be removed and this change to be included in the saved file, so the editor would end up being in "saved" state after the save.

Same thing with all other extensions disabled.

Trailing Spaces 0.2.11
VSCode 1.27.2
Windows 10 on 2 different machines (also with VSCode 1.26.1 on a Debian Linux machine).

Update (2019-04-14):
The latest Trailing Spaces 0.3.1 appears to save the trimming and does not leave the editor in "unsaved" state, so that's an improvement. But it still doesn't trim all the modified lines (the steps above still leave the 2nd line untrimmed).

[osumko]

"trailing-spaces.trimOnSave": true,
"trailing-spaces.deleteModifiedLinesOnly": true,

Still doesn't work.
vscode 1.33.1 mac
Trailing Spaces 0.3.1

Maybe it is better to use diff api like in git, so spaces will trim only on modified and added lines and files, so:

• if you editing existing file, only lines modified or added by you get trimmed.
• if you created new file, every line get trimmed.

[pablospe]

"trailing-spaces.trimOnSave": true,
"trailing-spaces.deleteModifiedLinesOnly": true,

I confirm this doesn't work for me neither. If trimOnSave is true, then trailing spaces are removed for whole file.

[kAlvaro]

Unless I'm missing something, either directives are ignored altogether. Saving the file wipes out every trailing space, no matter the settings.

[markhilkert]

This feature works for me. When I save, it only deletes lines I modified, not existing whitespace.

[pewscorner]

For me it still behaves like I described in the 2019-04-14 update - it doesn't trim all modified lines.

[shardulm94]

@pewscorner Do you observe the same behavior as mentioned in #43? If yes, this should be fixed in 0.4.0.

[pewscorner]

@shardulm94 I did a quick test, and it seems this #21 issue is gone in 0.4.0. Thanks!