Skip to content

Lazy server disable implementation #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 27, 2021
Merged

Lazy server disable implementation #401

merged 4 commits into from
Jan 27, 2021

Conversation

spyophobia
Copy link
Contributor

See #394

This is a lazy implementation that simply filters for disable before the vector of shadowsocks::ServerConfig is created.

  • Benefit: simply, lazy, no memory usage, no modification to shadowsocks::ServerConfig
  • Downside: Display trait for shadowsocks_service::Config is not aware of disabled servers

zonyitoo
zonyitoo requested changes Jan 27, 2021
View reviewed changes
@zonyitoo zonyitoo marked this pull request as ready for review January 27, 2021 12:24
spyophobia
spyophobia commented Jan 27, 2021
View reviewed changes
Copy link
Contributor Author

@spyophobia spyophobia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@zonyitoo zonyitoo merged commit 559db65 into shadowsocks:master Jan 27, 2021
@spyophobia spyophobia deleted the server_disable branch January 27, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zonyitoo zonyitoo zonyitoo requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@spyophobia @zonyitoo