Skip to content

Conversation

juliusikkala
Copy link
Contributor

@juliusikkala juliusikkala commented May 25, 2025

Fixes #7232.

  1. A crash was caused by the parser, as it tried to use declRefExpr, which is always nullptr in the else branch. It seems that candidate was meant instead, and declRefExpr is copy-paste residue there. (Also TIL how the scopes of variables introduced in an if-condition work in C++, it's very weird that this ever even compiled :D)
  2. The issue with the array index not being recognized as an integer was caused by the reference to the value property creating an OverloadExpr. CheckExpr is needed to resolve that overload before calling isScalarIntegerType.

@juliusikkala juliusikkala added the pr: non-breaking PRs without breaking changes label May 25, 2025
@juliusikkala juliusikkala marked this pull request as ready for review May 25, 2025 13:02
@juliusikkala juliusikkala requested a review from a team as a code owner May 25, 2025 13:02
@juliusikkala juliusikkala enabled auto-merge (squash) May 25, 2025 17:24
@juliusikkala juliusikkala merged commit 8ecb2c7 into shader-slang:master May 25, 2025
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues when accessing properties that implement an interface
2 participants